Skip to content

Conversation

GuillaumeGomez
Copy link
Contributor

Fixes intra-doc links appearing when generating documentation.

@GuillaumeGomez GuillaumeGomez force-pushed the fix-intra-doc-warning branch 5 times, most recently from 30b61c0 to f35a185 Compare August 12, 2025 16:30
@IQuick143 IQuick143 added C-Docs An addition or correction to our documentation D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 12, 2025
@GuillaumeGomez
Copy link
Contributor Author

CI finally passed. ^^'

@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-Cross-Cutting Impacts the entire engine and removed D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 12, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 12, 2025
@mockersf mockersf removed this pull request from the merge queue due to a manual request Aug 12, 2025
@mockersf
Copy link
Member

cancelled merged because I'm guessing this is the PR you mentioned there: #20386 (comment)
and building doc is currently failing because of another nightly bug :(

@alice-i-cecile alice-i-cecile added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Aug 12, 2025
@GuillaumeGomez
Copy link
Contributor Author

Yep it's the one! Is it a rustdoc bug (ie can I do something)?

@mockersf
Copy link
Member

it's rust-lang/rust#145151

@GuillaumeGomez
Copy link
Contributor Author

Already solved, perfect. :)

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Aug 12, 2025
@alice-i-cecile alice-i-cecile added this to the 0.17 milestone Aug 12, 2025
@alice-i-cecile
Copy link
Member

@mockersf do you have any outstanding complaints or can I merge this?

@mockersf
Copy link
Member

@alice-i-cecile waiting for a nightly with the bug mentioned above fixed

@alice-i-cecile alice-i-cecile added S-Blocked This cannot move forward until something else changes and removed S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Aug 13, 2025
@mockersf
Copy link
Member

building on rust nightly is fixed, we're back on failing docs 🎉 with

thread 'rustc' (14653) panicked at src/librustdoc/html/sources.rs:347:14:
only local crates should have sources emitted

on rust version 1.91.0-nightly (05f5a58e8 2025-08-19)

https://github.com/bevyengine/bevy/actions/runs/17105318871/job/48512604677

@GuillaumeGomez all yours!

@mockersf mockersf added this pull request to the merge queue Aug 20, 2025
Merged via the queue into bevyengine:main with commit 77966a7 Aug 20, 2025
50 checks passed
@mockersf
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Cross-Cutting Impacts the entire engine C-Docs An addition or correction to our documentation D-Trivial Nice and easy! A great choice to get started with Bevy S-Blocked This cannot move forward until something else changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants